![]() Losing genuine mail and sending undesired backscatter is sought,Īnd there can be some collateral damage on either side.įirst upstream SMTP client IP address: Īccording to a 'Received:' trace, the message apparently originated at: We do try to minimize backscatter for more prominent cases of UBE andįor infected mail, but for less obvious cases some balance between The message carried your return address, so it was either a genuine mailįrom you, or a sender address was faked and your e-mail address abusedīy third party, in which case we apologize for undesired notification. Our internal reference code for your message is 2543112-06/Q8cmmCBHhq9r > Another potential issue in that patch is that the signature change in git_deflate_bound forces size to unsigned long on the call to deflateBound (for newer zlib versions) and if that conversion is not faithful this will certainly not work.Was considered unsolicited bulk e-mail (UBE). > So I would think that something like > ->8 > diff -git a/zlib.c b/zlib.c > index 197a1acc7b.9cc6421eba 100644 > - a/zlib.c > +++ b/zlib.c > -51,13 +51,9 static void zlib_post_call(git_zstream *s) > bytes_consumed = s->z.next_in - s->next_in > bytes_produced = s->z.next_out - s->next_out > - if (s->z.total_out != s->total_out + bytes_produced) > - BUG("total_out mismatch") > - if (s->z.total_in != s->total_in + bytes_consumed) > - BUG("total_in mismatch") > - s->total_out = s->z.total_out > - s->total_in = s->z.total_in > + s->total_out += bytes_produced > + s->total_in += bytes_consumed > s->next_in = s->z.next_in > s->next_out = s->z.next_out > s->avail_in -= bytes_consumed > -8 > would make the patch more complete IMHO. There is even an FAQ entry for zlib at which warns about that potential issue. ![]() > And the first thing which bugs out when I do a quick test with committing a large file and fsck the repo is in zlib.c: > if (s->z.total_out != s->total_out + bytes_produced) > BUG("total_out mismatch") > here s->z.total_out is an unsigned long and s->total_out is size_t and this triggers the BUG message once the unsigned long wraps. > I've started playing around with the patch from Thorsten for getting unsigned long replaced in more places so that you can commit large files on platforms like Windows there unsigned long is 32-bit even on 64-bit OSes. Januar 2019 um 23:15 geschrieben: > * mk/use-size-t-in-zlib () 1 commit > - zlib.c: use size_t for size > The wrapper to call into zlib followed our long tradition to use > "unsigned long" for sizes of regions in memory, which have been > updated to use "size_t". Just my 2cents I'm not vetoing anything here, Would make the patch more complete IMHO.Īnother potential issue in that patch is that the signature change in git_deflate_bound forces size to unsigned long on the call to deflateBound (for newer zlib versions) and if that conversion is not faithful this will certainly not work. Here s->z.total_out is an unsigned long and s->total_out is size_t and this triggers the BUG message once the unsigned long wraps. If (s->z.total_out != s->total_out + bytes_produced) I've started playing around with the patch from Thorsten for getting unsigned long replaced in more places so that you can commit large files on platforms like Windows there unsigned long is 32-bit even on 64-bit OSes.Īnd the first thing which bugs out when I do a quick test with committing a large file and fsck the repo is in zlib.c: > * mk/use-size-t-in-zlib () 1 commit > - zlib.c: use size_t for size > The wrapper to call into zlib followed our long tradition to use > "unsigned long" for sizes of regions in memory, which have been > updated to use "size_t". X-Mailer: Open-Xchange Mailer v7.8.4-Rev48 Subject: mk/use-size-t-in-zlib [was: Re: What's cooking in git.git (Jan ![]() To: Junio C Hamano, Martin Koegler, =?utf-8?q?Torsten_B=C3=B6gers?= ![]() Received: from app04-neu.ox. () authenticatedīy running ExIM with esmtpsa " rhost-flags-OK-OK-OK-OK)īy with ESMTP id S1727838AbfAaR7V (ORCPT Received: from ( )īy mail.wl. (Postfix) with ESMTP id C727E30FA0 RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, X-Spam-Checker-Version: SpamAssassin 3.3.1 () on Received: by mail.wl. (Postfix, from userid 486) Received: from mail.wl. (localhost )īy mail.wl. (Postfix) with ESMTP id E5C4430FA0 Received: from mail.wl. (īy (Postfix) with ESMTP id F38BB13A4
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |